zephyr/tests/Kconfig
Ulf Magnusson ec3eff57e0 Kconfig: Use the first default with a satisfied condition
Up until now, Zephyr has patched Kconfig to use the last 'default' with
a satisfied condition, instead of the first one. I'm not sure why the
patch was added (it predates Kconfiglib), but I suspect it's related to
Kconfig.defconfig files.

There are at least three problems with the patch:

  1. It's inconsistent with how Kconfig works in other projects, which
     might confuse newcomers.

  2. Due to oversights, earlier 'range' properties are still preferred,
     as well as earlier 'default' properties on choices.

     In addition to being inconsistent, this makes it impossible to
     override 'range' properties and choice 'default' properties if the
     base definition of the symbol/choice already has 'range'/'default'
     properties.

     I've seen errors caused by the inconsistency, and I suspect there
     are more.

  3. A fork of Kconfiglib that adds the patch needs to be maintained.

Get rid of the patch and go back to standard Kconfig behavior, as
follows:

  1. Include the Kconfig.defconfig files first instead of last in
     Kconfig.zephyr.

  2. Include boards/Kconfig and arch/<arch>/Kconfig first instead of
     last in arch/Kconfig.

  3. Include arch/<arch>/soc/*/Kconfig first instead of last in
     arch/<arch>/Kconfig.

  4. Swap a few other 'source's to preserve behavior for some scattered
     symbols with multiple definitions.

     Swap 'source's in some no-op cases too, where it might match the
     intent.

  5. Reverse the defaults on symbol definitions that have more than one
     default.

     Skip defaults that are mutually exclusive, e.g. where each default
     has an 'if <some board>' condition. They are already safe.

  6. Remove the prefer-later-defaults patch from Kconfiglib.

Testing was done with a Python script that lists all Kconfig
symbols/choices with multiple defaults, along with a whitelist of fixed
symbols. The script also verifies that there are no "unreachable"
defaults hidden by defaults without conditions

As an additional test, zephyr/.config was generated before and after the
change for several samples and checked to be identical (after sorting).

This commit includes some default-related cleanups as well:

  - Simplify some symbol definitions, e.g. where a default has 'if FOO'
    when the symbol already has 'depends on FOO'.

  - Remove some redundant 'default ""' for string symbols. This is the
    implicit default.

Piggyback fixes for swapped ranges on BT_L2CAP_RX_MTU and
BT_L2CAP_TX_MTU (caused by confusing inconsistency).

Piggyback some fixes for style nits too, e.g. unindented help texts.

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
2018-08-10 12:38:28 -07:00

64 lines
1.6 KiB
Plaintext

#
# Copyright (c) 2016 Intel Corporation
#
# SPDX-License-Identifier: Apache-2.0
#
menu Testing
source "tests/ztest/Kconfig"
config TEST
bool "Mark project as a test"
help
Mark a project or an application as a test. This will enable a few
test defaults.
config TEST_EXTRA_STACKSIZE
int "Test function extra thread stack size"
default 768 if XTENSA
default 0
help
Additional stack for tests on some platform where default is not
enough.
config COVERAGE
bool "Create coverage data"
depends on NATIVE_APPLICATION
help
This option will build your application with the -coverage option
which will generate data that can be used to create coverage reports.
Currently this is fully supported only on the native POSIX port.
config TEST_USERSPACE
bool "Enable userspace if available"
depends on ARCH_HAS_USERSPACE
depends on TEST
select USERSPACE
select APPLICATION_MEMORY
select DYNAMIC_OBJECTS
default y
help
This option will help test the userspace mode. This can be enabled
only when CONFIG_ARCH_HAS_USERSPACE is set.
config TEST_HW_STACK_PROTECTION
bool "Enable hardware-based stack overflow detection if available"
depends on ARCH_HAS_STACK_PROTECTION
depends on TEST
select HW_STACK_PROTECTION
default y
help
This option will enable hardware-based stack protection by default
for all test cases if the hardware supports it.
config TEST_FLASH_DRIVERS
bool "Test flash drivers"
depends on BOARD_QEMU_X86
select FLASH_HAS_DRIVER_ENABLED
select FLASH_HAS_PAGE_LAYOUT
help
This option will help test the flash drivers. This should be enabled
only when using qemu_x86.
endmenu