mirror of
https://github.com/zephyrproject-rtos/zephyr
synced 2025-08-05 11:35:22 +00:00
The goal of this patch is to replace the 'void *' parameter by 'struct device *' if they use such variable or just 'const void *' on all relevant ISRs This will avoid not-so-nice const qualifier tweaks when device instances will be constant. Note that only the ISR passed to IRQ_CONNECT are of interest here. In order to do so, the script fix_isr.py below is necessary: from pathlib import Path import subprocess import pickle import mmap import sys import re import os cocci_template = """ @r_fix_isr_0 @ type ret_type; identifier P; identifier D; @@ -ret_type <!fn!>(void *P) +ret_type <!fn!>(const struct device *P) { ... ( const struct device *D = (const struct device *)P; | const struct device *D = P; ) ... } @r_fix_isr_1 @ type ret_type; identifier P; identifier D; @@ -ret_type <!fn!>(void *P) +ret_type <!fn!>(const struct device *P) { ... const struct device *D; ... ( D = (const struct device *)P; | D = P; ) ... } @r_fix_isr_2 @ type ret_type; identifier A; @@ -ret_type <!fn!>(void *A) +ret_type <!fn!>(const void *A) { ... } @r_fix_isr_3 @ const struct device *D; @@ -<!fn!>((void *)D); +<!fn!>(D); @r_fix_isr_4 @ type ret_type; identifier D; identifier P; @@ -ret_type <!fn!>(const struct device *P) +ret_type <!fn!>(const struct device *D) { ... ( -const struct device *D = (const struct device *)P; | -const struct device *D = P; ) ... } @r_fix_isr_5 @ type ret_type; identifier D; identifier P; @@ -ret_type <!fn!>(const struct device *P) +ret_type <!fn!>(const struct device *D) { ... -const struct device *D; ... ( -D = (const struct device *)P; | -D = P; ) ... } """ def find_isr(fn): db = [] data = None start = 0 try: with open(fn, 'r+') as f: data = str(mmap.mmap(f.fileno(), 0).read()) except Exception as e: return db while True: isr = "" irq = data.find('IRQ_CONNECT', start) while irq > -1: p = 1 arg = 1 p_o = data.find('(', irq) if p_o < 0: irq = -1 break; pos = p_o + 1 while p > 0: if data[pos] == ')': p -= 1 elif data[pos] == '(': p += 1 elif data[pos] == ',' and p == 1: arg += 1 if arg == 3: isr += data[pos] pos += 1 isr = isr.strip(',\\n\\t ') if isr not in db and len(isr) > 0: db.append(isr) start = pos break if irq < 0: break return db def patch_isr(fn, isr_list): if len(isr_list) <= 0: return for isr in isr_list: tmplt = cocci_template.replace('<!fn!>', isr) with open('/tmp/isr_fix.cocci', 'w') as f: f.write(tmplt) cmd = ['spatch', '--sp-file', '/tmp/isr_fix.cocci', '--in-place', fn] subprocess.run(cmd) def process_files(path): if path.is_file() and path.suffix in ['.h', '.c']: p = str(path.parent) + '/' + path.name isr_list = find_isr(p) patch_isr(p, isr_list) elif path.is_dir(): for p in path.iterdir(): process_files(p) if len(sys.argv) < 2: print("You need to provide a dir/file path") sys.exit(1) process_files(Path(sys.argv[1])) And is run: ./fix_isr.py <zephyr root directory> Finally, some files needed manual fixes such. Fixes #27399 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
231 lines
5.1 KiB
C
231 lines
5.1 KiB
C
/*
|
|
* Copyright (c) 2018, NXP
|
|
*
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
#define DT_DRV_COMPAT nxp_imx_mu
|
|
|
|
#include <errno.h>
|
|
#include <string.h>
|
|
#include <device.h>
|
|
#include <soc.h>
|
|
#include <drivers/ipm.h>
|
|
#include <mu_imx.h>
|
|
|
|
#define MU(config) ((MU_Type *)config->base)
|
|
|
|
#if ((CONFIG_IPM_IMX_MAX_DATA_SIZE % 4) != 0)
|
|
#error CONFIG_IPM_IMX_MAX_DATA_SIZE is invalid
|
|
#endif
|
|
|
|
#define IMX_IPM_DATA_REGS (CONFIG_IPM_IMX_MAX_DATA_SIZE / 4)
|
|
|
|
struct imx_mu_config {
|
|
MU_Type *base;
|
|
void (*irq_config_func)(const struct device *dev);
|
|
};
|
|
|
|
struct imx_mu_data {
|
|
ipm_callback_t callback;
|
|
void *user_data;
|
|
};
|
|
|
|
static void imx_mu_isr(const struct device *dev)
|
|
{
|
|
const struct imx_mu_config *config = dev->config;
|
|
MU_Type *base = MU(config);
|
|
struct imx_mu_data *data = dev->data;
|
|
uint32_t data32[IMX_IPM_DATA_REGS];
|
|
uint32_t status_reg;
|
|
int32_t id;
|
|
int32_t i;
|
|
bool all_registers_full;
|
|
|
|
status_reg = base->SR >>= MU_SR_RFn_SHIFT;
|
|
|
|
for (id = CONFIG_IPM_IMX_MAX_ID_VAL; id >= 0; id--) {
|
|
if (status_reg & 0x1U) {
|
|
/*
|
|
* Check if all receive registers are full. If not,
|
|
* it is violation of the protocol (status register
|
|
* are set earlier than all receive registers).
|
|
* Do not read any of the registers in such situation.
|
|
*/
|
|
all_registers_full = true;
|
|
for (i = 0; i < IMX_IPM_DATA_REGS; i++) {
|
|
if (!MU_IsRxFull(base,
|
|
(id * IMX_IPM_DATA_REGS) + i)) {
|
|
all_registers_full = false;
|
|
break;
|
|
}
|
|
}
|
|
if (all_registers_full) {
|
|
for (i = 0; i < IMX_IPM_DATA_REGS; i++) {
|
|
MU_ReceiveMsg(base,
|
|
(id * IMX_IPM_DATA_REGS) + i,
|
|
&data32[i]);
|
|
}
|
|
|
|
if (data->callback) {
|
|
data->callback(dev, data->user_data,
|
|
(uint32_t)id,
|
|
&data32[0]);
|
|
}
|
|
}
|
|
}
|
|
status_reg >>= IMX_IPM_DATA_REGS;
|
|
}
|
|
|
|
/* Add for ARM errata 838869, affects Cortex-M4, Cortex-M4F
|
|
* Store immediate overlapping exception return operation
|
|
* might vector to incorrect interrupt
|
|
*/
|
|
#if defined __CORTEX_M && (__CORTEX_M == 4U)
|
|
__DSB();
|
|
#endif
|
|
}
|
|
|
|
static int imx_mu_ipm_send(const struct device *dev, int wait, uint32_t id,
|
|
const void *data, int size)
|
|
{
|
|
const struct imx_mu_config *config = dev->config;
|
|
MU_Type *base = MU(config);
|
|
uint32_t data32[IMX_IPM_DATA_REGS];
|
|
mu_status_t status;
|
|
int i;
|
|
|
|
if (id > CONFIG_IPM_IMX_MAX_ID_VAL) {
|
|
return -EINVAL;
|
|
}
|
|
|
|
if (size > CONFIG_IPM_IMX_MAX_DATA_SIZE) {
|
|
return -EMSGSIZE;
|
|
}
|
|
|
|
/* Actual message is passing using 32 bits registers */
|
|
memcpy(data32, data, size);
|
|
|
|
for (i = 0; i < IMX_IPM_DATA_REGS; i++) {
|
|
status = MU_TrySendMsg(base, id * IMX_IPM_DATA_REGS + i,
|
|
data32[i]);
|
|
if (status == kStatus_MU_TxNotEmpty) {
|
|
return -EBUSY;
|
|
}
|
|
}
|
|
|
|
if (wait) {
|
|
while (!MU_IsTxEmpty(base,
|
|
(id * IMX_IPM_DATA_REGS) + IMX_IPM_DATA_REGS - 1)) {
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int imx_mu_ipm_max_data_size_get(const struct device *dev)
|
|
{
|
|
ARG_UNUSED(dev);
|
|
|
|
return CONFIG_IPM_IMX_MAX_DATA_SIZE;
|
|
}
|
|
|
|
static uint32_t imx_mu_ipm_max_id_val_get(const struct device *dev)
|
|
{
|
|
ARG_UNUSED(dev);
|
|
|
|
return CONFIG_IPM_IMX_MAX_ID_VAL;
|
|
}
|
|
|
|
static void imx_mu_ipm_register_callback(const struct device *dev,
|
|
ipm_callback_t cb,
|
|
void *user_data)
|
|
{
|
|
struct imx_mu_data *driver_data = dev->data;
|
|
|
|
driver_data->callback = cb;
|
|
driver_data->user_data = user_data;
|
|
}
|
|
|
|
static int imx_mu_ipm_set_enabled(const struct device *dev, int enable)
|
|
{
|
|
const struct imx_mu_config *config = dev->config;
|
|
MU_Type *base = MU(config);
|
|
|
|
#if CONFIG_IPM_IMX_MAX_DATA_SIZE_4
|
|
if (enable) {
|
|
MU_EnableRxFullInt(base, 0U);
|
|
MU_EnableRxFullInt(base, 1U);
|
|
MU_EnableRxFullInt(base, 2U);
|
|
MU_EnableRxFullInt(base, 3U);
|
|
} else {
|
|
MU_DisableRxFullInt(base, 0U);
|
|
MU_DisableRxFullInt(base, 1U);
|
|
MU_DisableRxFullInt(base, 2U);
|
|
MU_DisableRxFullInt(base, 3U);
|
|
}
|
|
#elif CONFIG_IPM_IMX_MAX_DATA_SIZE_8
|
|
if (enable) {
|
|
MU_EnableRxFullInt(base, 1U);
|
|
MU_EnableRxFullInt(base, 3U);
|
|
} else {
|
|
MU_DisableRxFullInt(base, 1U);
|
|
MU_DisableRxFullInt(base, 3U);
|
|
}
|
|
#elif CONFIG_IPM_IMX_MAX_DATA_SIZE_16
|
|
if (enable) {
|
|
MU_EnableRxFullInt(base, 3U);
|
|
} else {
|
|
MU_DisableRxFullInt(base, 3U);
|
|
}
|
|
#else
|
|
#error "CONFIG_IPM_IMX_MAX_DATA_SIZE_n is not set"
|
|
#endif
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int imx_mu_init(const struct device *dev)
|
|
{
|
|
const struct imx_mu_config *config = dev->config;
|
|
|
|
MU_Init(MU(config));
|
|
config->irq_config_func(dev);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct ipm_driver_api imx_mu_driver_api = {
|
|
.send = imx_mu_ipm_send,
|
|
.register_callback = imx_mu_ipm_register_callback,
|
|
.max_data_size_get = imx_mu_ipm_max_data_size_get,
|
|
.max_id_val_get = imx_mu_ipm_max_id_val_get,
|
|
.set_enabled = imx_mu_ipm_set_enabled
|
|
};
|
|
|
|
/* Config MU */
|
|
|
|
static void imx_mu_config_func_b(const struct device *dev);
|
|
|
|
static const struct imx_mu_config imx_mu_b_config = {
|
|
.base = (MU_Type *)DT_INST_REG_ADDR(0),
|
|
.irq_config_func = imx_mu_config_func_b,
|
|
};
|
|
|
|
static struct imx_mu_data imx_mu_b_data;
|
|
|
|
DEVICE_AND_API_INIT(mu_b, DT_INST_LABEL(0),
|
|
&imx_mu_init,
|
|
&imx_mu_b_data, &imx_mu_b_config,
|
|
PRE_KERNEL_1, CONFIG_KERNEL_INIT_PRIORITY_DEFAULT,
|
|
&imx_mu_driver_api);
|
|
|
|
static void imx_mu_config_func_b(const struct device *dev)
|
|
{
|
|
IRQ_CONNECT(DT_INST_IRQN(0),
|
|
DT_INST_IRQ(0, priority),
|
|
imx_mu_isr, DEVICE_GET(mu_b), 0);
|
|
|
|
irq_enable(DT_INST_IRQN(0));
|
|
}
|