zephyr/drivers/sensor/sensor_tmp007.c
Bogdan Davidoaia e8d0090808 sensor: tmp007: fix negative sample values bug
Fix bug that caused negative temperature values to be computed incorrectly.
The sign bit needs to be perserved, when extracting the data sample from
the TMP007_REG_TOBJ register.

Jira: ZEP-499
Change-Id: Idbebd48b3164d7d4883352ef7128ef73be70e1b2
Signed-off-by: Bogdan Davidoaia <bogdan.m.davidoaia@intel.com>
2016-06-30 17:50:05 +00:00

151 lines
3.4 KiB
C

/*
* Copyright (c) 2016 Intel Corporation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include <device.h>
#include <i2c.h>
#include <gpio.h>
#include <misc/byteorder.h>
#include <misc/util.h>
#include <nanokernel.h>
#include <sensor.h>
#include <misc/__assert.h>
#include "sensor_tmp007.h"
int tmp007_reg_read(struct tmp007_data *drv_data, uint8_t reg, uint16_t *val)
{
struct i2c_msg msgs[2] = {
{
.buf = &reg,
.len = 1,
.flags = I2C_MSG_WRITE | I2C_MSG_RESTART,
},
{
.buf = (uint8_t *)val,
.len = 2,
.flags = I2C_MSG_READ | I2C_MSG_STOP,
},
};
if (i2c_transfer(drv_data->i2c, msgs, 2, TMP007_I2C_ADDRESS) < 0) {
return -EIO;
}
*val = sys_be16_to_cpu(*val);
return 0;
}
int tmp007_reg_write(struct tmp007_data *drv_data, uint8_t reg, uint16_t val)
{
uint8_t tx_buf[3] = {reg, val >> 8, val & 0xFF};
return i2c_write(drv_data->i2c, tx_buf, sizeof(tx_buf),
TMP007_I2C_ADDRESS);
}
int tmp007_reg_update(struct tmp007_data *drv_data, uint8_t reg,
uint16_t mask, uint16_t val)
{
uint16_t old_val = 0;
uint16_t new_val;
if (tmp007_reg_read(drv_data, reg, &old_val) < 0) {
return -EIO;
}
new_val = old_val & ~mask;
new_val |= val & mask;
return tmp007_reg_write(drv_data, reg, new_val);
}
static int tmp007_sample_fetch(struct device *dev, enum sensor_channel chan)
{
struct tmp007_data *drv_data = dev->driver_data;
uint16_t val;
__ASSERT(chan == SENSOR_CHAN_ALL || chan == SENSOR_CHAN_TEMP);
if (tmp007_reg_read(drv_data, TMP007_REG_TOBJ, &val) < 0) {
return -EIO;
}
if (val & TMP007_DATA_INVALID_BIT) {
return -EIO;
}
drv_data->sample = arithmetic_shift_right((int16_t)val, 2);
return 0;
}
static int tmp007_channel_get(struct device *dev,
enum sensor_channel chan,
struct sensor_value *val)
{
struct tmp007_data *drv_data = dev->driver_data;
int32_t uval;
if (chan != SENSOR_CHAN_TEMP) {
return -ENOTSUP;
}
uval = (int32_t)drv_data->sample * TMP007_TEMP_SCALE;
val->type = SENSOR_VALUE_TYPE_INT_PLUS_MICRO;
val->val1 = uval / 1000000;
val->val2 = uval % 1000000;
return 0;
}
static struct sensor_driver_api tmp007_driver_api = {
#ifdef CONFIG_TMP007_TRIGGER
.attr_set = tmp007_attr_set,
.trigger_set = tmp007_trigger_set,
#endif
.sample_fetch = tmp007_sample_fetch,
.channel_get = tmp007_channel_get,
};
int tmp007_init(struct device *dev)
{
struct tmp007_data *drv_data = dev->driver_data;
drv_data->i2c = device_get_binding(CONFIG_TMP007_I2C_MASTER_DEV_NAME);
if (drv_data->i2c == NULL) {
SYS_LOG_DBG("Failed to get pointer to %s device!",
CONFIG_TMP007_I2C_MASTER_DEV_NAME);
return -EINVAL;
}
#ifdef CONFIG_TMP007_TRIGGER
if (tmp007_init_interrupt(dev) < 0) {
SYS_LOG_DBG("Failed to initialize interrupt!");
return -EIO;
}
#endif
dev->driver_api = &tmp007_driver_api;
return 0;
}
struct tmp007_data tmp007_driver;
DEVICE_INIT(tmp007, CONFIG_TMP007_NAME, tmp007_init, &tmp007_driver,
NULL, SECONDARY, CONFIG_TMP007_INIT_PRIORITY);