mirror of
https://github.com/zephyrproject-rtos/zephyr
synced 2025-09-14 15:51:56 +00:00
This commit refactors kernel and arch headers to establish a boundary between private and public interface headers. The refactoring strategy used in this commit is detailed in the issue This commit introduces the following major changes: 1. Establish a clear boundary between private and public headers by removing "kernel/include" and "arch/*/include" from the global include paths. Ideally, only kernel/ and arch/*/ source files should reference the headers in these directories. If these headers must be used by a component, these include paths shall be manually added to the CMakeLists.txt file of the component. This is intended to discourage applications from including private kernel and arch headers either knowingly and unknowingly. - kernel/include/ (PRIVATE) This directory contains the private headers that provide private kernel definitions which should not be visible outside the kernel and arch source code. All public kernel definitions must be added to an appropriate header located under include/. - arch/*/include/ (PRIVATE) This directory contains the private headers that provide private architecture-specific definitions which should not be visible outside the arch and kernel source code. All public architecture- specific definitions must be added to an appropriate header located under include/arch/*/. - include/ AND include/sys/ (PUBLIC) This directory contains the public headers that provide public kernel definitions which can be referenced by both kernel and application code. - include/arch/*/ (PUBLIC) This directory contains the public headers that provide public architecture-specific definitions which can be referenced by both kernel and application code. 2. Split arch_interface.h into "kernel-to-arch interface" and "public arch interface" divisions. - kernel/include/kernel_arch_interface.h * provides private "kernel-to-arch interface" definition. * includes arch/*/include/kernel_arch_func.h to ensure that the interface function implementations are always available. * includes sys/arch_interface.h so that public arch interface definitions are automatically included when including this file. - arch/*/include/kernel_arch_func.h * provides architecture-specific "kernel-to-arch interface" implementation. * only the functions that will be used in kernel and arch source files are defined here. - include/sys/arch_interface.h * provides "public arch interface" definition. * includes include/arch/arch_inlines.h to ensure that the architecture-specific public inline interface function implementations are always available. - include/arch/arch_inlines.h * includes architecture-specific arch_inlines.h in include/arch/*/arch_inline.h. - include/arch/*/arch_inline.h * provides architecture-specific "public arch interface" inline function implementation. * supersedes include/sys/arch_inline.h. 3. Refactor kernel and the existing architecture implementations. - Remove circular dependency of kernel and arch headers. The following general rules should be observed: * Never include any private headers from public headers * Never include kernel_internal.h in kernel_arch_data.h * Always include kernel_arch_data.h from kernel_arch_func.h * Never include kernel.h from kernel_struct.h either directly or indirectly. Only add the kernel structures that must be referenced from public arch headers in this file. - Relocate syscall_handler.h to include/ so it can be used in the public code. This is necessary because many user-mode public codes reference the functions defined in this header. - Relocate kernel_arch_thread.h to include/arch/*/thread.h. This is necessary to provide architecture-specific thread definition for 'struct k_thread' in kernel.h. - Remove any private header dependencies from public headers using the following methods: * If dependency is not required, simply omit * If dependency is required, - Relocate a portion of the required dependencies from the private header to an appropriate public header OR - Relocate the required private header to make it public. This commit supersedes #20047, addresses #19666, and fixes #3056. Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
212 lines
4.8 KiB
C
212 lines
4.8 KiB
C
/*
|
|
* Copyright (c) 2017 Intel Corporation
|
|
*
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
/*
|
|
* @file test dynamic memory allocation using C libraries
|
|
*
|
|
* This module verifies that the various dynamic memory allocation functions
|
|
* works fine with minimal C library and newlib C library.
|
|
*
|
|
* IMPORTANT: The module only ensures that each supported library is present,
|
|
* and that a bare minimum of its functionality is operating correctly. It does
|
|
* NOT guarantee that ALL standards-defined functionality is present, nor does
|
|
* it guarantee that ALL functionality provided is working correctly.
|
|
*/
|
|
|
|
#include <zephyr.h>
|
|
#include <ztest.h>
|
|
#include <stdlib.h>
|
|
#include <errno.h>
|
|
|
|
#define BUF_LEN 10
|
|
|
|
/**
|
|
* @brief Test dynamic memory allocation using malloc
|
|
*
|
|
* @see malloc(), free()
|
|
*/
|
|
void test_malloc(void)
|
|
{
|
|
/* Initialize error number to avoid garbage value, in case of SUCCESS */
|
|
int *iptr = NULL;
|
|
|
|
iptr = malloc(BUF_LEN * sizeof(int));
|
|
zassert_not_null((iptr), "malloc failed, errno: %d", errno);
|
|
memset(iptr, 'p', BUF_LEN * sizeof(int));
|
|
free(iptr);
|
|
iptr = NULL;
|
|
}
|
|
|
|
/**
|
|
* @brief Test dynamic memory allocation free function
|
|
*
|
|
* @see free()
|
|
*/
|
|
void test_free(void)
|
|
{
|
|
/*
|
|
* In free, if ptr is passed as NULL, no operation is performed
|
|
* Just make sure, no exception occurs and test pass
|
|
*/
|
|
free(NULL);
|
|
}
|
|
|
|
/**
|
|
* @brief Test dynamic memory allocation using calloc
|
|
*
|
|
* @see calloc(), free()
|
|
*/
|
|
#define CALLOC_BUFLEN (200)
|
|
static ZTEST_BMEM unsigned char zerobuf[CALLOC_BUFLEN];
|
|
|
|
void test_calloc(void)
|
|
{
|
|
char *cptr = NULL;
|
|
|
|
cptr = calloc(CALLOC_BUFLEN, sizeof(char));
|
|
zassert_not_null((cptr), "calloc failed, errno: %d", errno);
|
|
zassert_true(((memcmp(cptr, zerobuf, CALLOC_BUFLEN)) == 0),
|
|
"calloc failed to set zero value, errno: %d", errno);
|
|
memset(cptr, 'p', CALLOC_BUFLEN);
|
|
free(cptr);
|
|
cptr = NULL;
|
|
}
|
|
|
|
/**
|
|
* @brief Test dynamic memory allocation using realloc
|
|
*
|
|
* @see malloc(), realloc(), free()
|
|
*/
|
|
ZTEST_BMEM unsigned char filled_buf[BUF_LEN];
|
|
|
|
void test_realloc(void)
|
|
{
|
|
char orig_size = BUF_LEN;
|
|
char new_size = BUF_LEN + BUF_LEN;
|
|
char *ptr = NULL;
|
|
char *reloc_ptr = NULL;
|
|
|
|
ptr = malloc(orig_size);
|
|
|
|
zassert_not_null((ptr), "malloc failed, errno: %d", errno);
|
|
(void)memset(ptr, 'p', orig_size);
|
|
|
|
reloc_ptr = realloc(ptr, new_size);
|
|
|
|
zassert_not_null(reloc_ptr, "realloc failed, errno: %d", errno);
|
|
zassert_not_null((ptr), "malloc/realloc failed, errno: %d", errno);
|
|
ptr = reloc_ptr;
|
|
|
|
(void)memset(filled_buf, 'p', BUF_LEN);
|
|
zassert_true(((memcmp(ptr, filled_buf, BUF_LEN)) == 0),
|
|
"realloc failed to copy malloc data, errno: %d", errno);
|
|
|
|
free(ptr);
|
|
ptr = NULL;
|
|
}
|
|
|
|
/**
|
|
* @brief Test dynamic memory allocation using reallocarray
|
|
*
|
|
* @see malloc(), reallocarray(), free()
|
|
*/
|
|
#ifdef CONFIG_NEWLIB_LIBC
|
|
void test_reallocarray(void)
|
|
{
|
|
/* reallocarray not implemented for newlib */
|
|
ztest_test_skip();
|
|
}
|
|
#else
|
|
void test_reallocarray(void)
|
|
{
|
|
char orig_size = BUF_LEN;
|
|
char *ptr = NULL;
|
|
|
|
ptr = malloc(orig_size);
|
|
|
|
zassert_not_null((ptr), "malloc failed, errno: %d", errno);
|
|
(void)memset(ptr, 'p', orig_size);
|
|
|
|
char *reloc_ptr = reallocarray(ptr, 2, orig_size);
|
|
|
|
zassert_not_null(reloc_ptr, "reallocarray failed");
|
|
zassert_not_null((ptr), "malloc/reallocarray failed, errno: %d", errno);
|
|
ptr = reloc_ptr;
|
|
|
|
(void)memset(filled_buf, 'p', BUF_LEN);
|
|
zassert_true(((memcmp(ptr, filled_buf, BUF_LEN)) == 0),
|
|
"realloc failed to copy malloc data, errno: %d", errno);
|
|
|
|
free(ptr);
|
|
ptr = NULL;
|
|
}
|
|
#endif
|
|
|
|
|
|
#define MAX_LEN (10 * BUF_LEN)
|
|
|
|
/**
|
|
* @brief Test dynamic memory allocation functions
|
|
*
|
|
* @see malloc(), calloc(), realloc(), free()
|
|
*/
|
|
void test_memalloc_all(void)
|
|
{
|
|
char *mlc_ptr = NULL;
|
|
char *clc_ptr = NULL;
|
|
char *reloc_ptr = NULL;
|
|
int orig_size = BUF_LEN;
|
|
int new_size = MAX_LEN;
|
|
|
|
mlc_ptr = malloc(orig_size);
|
|
zassert_not_null((mlc_ptr), "malloc failed, errno: %d", errno);
|
|
|
|
clc_ptr = calloc(100, sizeof(char));
|
|
zassert_not_null((clc_ptr), "calloc failed, errno: %d", errno);
|
|
|
|
reloc_ptr = realloc(mlc_ptr, new_size);
|
|
zassert_not_null(reloc_ptr, "realloc failed, errno: %d", errno);
|
|
zassert_not_null((mlc_ptr), "malloc/realloc failed, errno: %d", errno);
|
|
mlc_ptr = reloc_ptr;
|
|
|
|
free(mlc_ptr);
|
|
free(clc_ptr);
|
|
mlc_ptr = NULL;
|
|
clc_ptr = NULL;
|
|
reloc_ptr = NULL;
|
|
}
|
|
|
|
/**
|
|
*
|
|
* @brief Test dynamic memory allocation upto maximum size
|
|
* Negative test case
|
|
*
|
|
*/
|
|
|
|
void test_memalloc_max(void)
|
|
{
|
|
char *ptr = NULL;
|
|
|
|
ptr = malloc(0x7fffffff);
|
|
zassert_is_null(ptr, "malloc passed unexpectedly");
|
|
free(ptr);
|
|
ptr = NULL;
|
|
}
|
|
|
|
void test_main(void)
|
|
{
|
|
ztest_test_suite(test_c_lib_dynamic_memalloc,
|
|
ztest_user_unit_test(test_malloc),
|
|
ztest_user_unit_test(test_free),
|
|
ztest_user_unit_test(test_calloc),
|
|
ztest_user_unit_test(test_realloc),
|
|
ztest_user_unit_test(test_reallocarray),
|
|
ztest_user_unit_test(test_memalloc_all),
|
|
ztest_user_unit_test(test_memalloc_max)
|
|
);
|
|
ztest_run_test_suite(test_c_lib_dynamic_memalloc);
|
|
}
|