mirror of
https://github.com/zephyrproject-rtos/zephyr
synced 2025-08-07 10:55:20 +00:00
The goal of this patch is to replace the 'void *' parameter by 'struct device *' if they use such variable or just 'const void *' on all relevant ISRs This will avoid not-so-nice const qualifier tweaks when device instances will be constant. Note that only the ISR passed to IRQ_CONNECT are of interest here. In order to do so, the script fix_isr.py below is necessary: from pathlib import Path import subprocess import pickle import mmap import sys import re import os cocci_template = """ @r_fix_isr_0 @ type ret_type; identifier P; identifier D; @@ -ret_type <!fn!>(void *P) +ret_type <!fn!>(const struct device *P) { ... ( const struct device *D = (const struct device *)P; | const struct device *D = P; ) ... } @r_fix_isr_1 @ type ret_type; identifier P; identifier D; @@ -ret_type <!fn!>(void *P) +ret_type <!fn!>(const struct device *P) { ... const struct device *D; ... ( D = (const struct device *)P; | D = P; ) ... } @r_fix_isr_2 @ type ret_type; identifier A; @@ -ret_type <!fn!>(void *A) +ret_type <!fn!>(const void *A) { ... } @r_fix_isr_3 @ const struct device *D; @@ -<!fn!>((void *)D); +<!fn!>(D); @r_fix_isr_4 @ type ret_type; identifier D; identifier P; @@ -ret_type <!fn!>(const struct device *P) +ret_type <!fn!>(const struct device *D) { ... ( -const struct device *D = (const struct device *)P; | -const struct device *D = P; ) ... } @r_fix_isr_5 @ type ret_type; identifier D; identifier P; @@ -ret_type <!fn!>(const struct device *P) +ret_type <!fn!>(const struct device *D) { ... -const struct device *D; ... ( -D = (const struct device *)P; | -D = P; ) ... } """ def find_isr(fn): db = [] data = None start = 0 try: with open(fn, 'r+') as f: data = str(mmap.mmap(f.fileno(), 0).read()) except Exception as e: return db while True: isr = "" irq = data.find('IRQ_CONNECT', start) while irq > -1: p = 1 arg = 1 p_o = data.find('(', irq) if p_o < 0: irq = -1 break; pos = p_o + 1 while p > 0: if data[pos] == ')': p -= 1 elif data[pos] == '(': p += 1 elif data[pos] == ',' and p == 1: arg += 1 if arg == 3: isr += data[pos] pos += 1 isr = isr.strip(',\\n\\t ') if isr not in db and len(isr) > 0: db.append(isr) start = pos break if irq < 0: break return db def patch_isr(fn, isr_list): if len(isr_list) <= 0: return for isr in isr_list: tmplt = cocci_template.replace('<!fn!>', isr) with open('/tmp/isr_fix.cocci', 'w') as f: f.write(tmplt) cmd = ['spatch', '--sp-file', '/tmp/isr_fix.cocci', '--in-place', fn] subprocess.run(cmd) def process_files(path): if path.is_file() and path.suffix in ['.h', '.c']: p = str(path.parent) + '/' + path.name isr_list = find_isr(p) patch_isr(p, isr_list) elif path.is_dir(): for p in path.iterdir(): process_files(p) if len(sys.argv) < 2: print("You need to provide a dir/file path") sys.exit(1) process_files(Path(sys.argv[1])) And is run: ./fix_isr.py <zephyr root directory> Finally, some files needed manual fixes such. Fixes #27399 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
192 lines
4.4 KiB
C
192 lines
4.4 KiB
C
/*
|
|
*
|
|
* Copyright (c) 2018, NXP
|
|
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
#define DT_DRV_COMPAT nxp_kinetis_wdog
|
|
|
|
#include <drivers/watchdog.h>
|
|
#include <drivers/clock_control.h>
|
|
#include <fsl_wdog.h>
|
|
|
|
#define LOG_LEVEL CONFIG_WDT_LOG_LEVEL
|
|
#include <logging/log.h>
|
|
LOG_MODULE_REGISTER(wdt_mcux_wdog);
|
|
|
|
#define MIN_TIMEOUT 4
|
|
|
|
struct mcux_wdog_config {
|
|
WDOG_Type *base;
|
|
char *clock_name;
|
|
clock_control_subsys_t clock_subsys;
|
|
void (*irq_config_func)(const struct device *dev);
|
|
};
|
|
|
|
struct mcux_wdog_data {
|
|
wdt_callback_t callback;
|
|
wdog_config_t wdog_config;
|
|
bool timeout_valid;
|
|
};
|
|
|
|
static int mcux_wdog_setup(const struct device *dev, uint8_t options)
|
|
{
|
|
const struct mcux_wdog_config *config = dev->config;
|
|
struct mcux_wdog_data *data = dev->data;
|
|
WDOG_Type *base = config->base;
|
|
|
|
if (!data->timeout_valid) {
|
|
LOG_ERR("No valid timeouts installed");
|
|
return -EINVAL;
|
|
}
|
|
|
|
data->wdog_config.workMode.enableStop =
|
|
(options & WDT_OPT_PAUSE_IN_SLEEP) == 0U;
|
|
|
|
data->wdog_config.workMode.enableDebug =
|
|
(options & WDT_OPT_PAUSE_HALTED_BY_DBG) == 0U;
|
|
|
|
WDOG_Init(base, &data->wdog_config);
|
|
LOG_DBG("Setup the watchdog");
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int mcux_wdog_disable(const struct device *dev)
|
|
{
|
|
const struct mcux_wdog_config *config = dev->config;
|
|
struct mcux_wdog_data *data = dev->data;
|
|
WDOG_Type *base = config->base;
|
|
|
|
WDOG_Deinit(base);
|
|
data->timeout_valid = false;
|
|
LOG_DBG("Disabled the watchdog");
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int mcux_wdog_install_timeout(const struct device *dev,
|
|
const struct wdt_timeout_cfg *cfg)
|
|
{
|
|
const struct mcux_wdog_config *config = dev->config;
|
|
struct mcux_wdog_data *data = dev->data;
|
|
const struct device *clock_dev;
|
|
uint32_t clock_freq;
|
|
|
|
if (data->timeout_valid) {
|
|
LOG_ERR("No more timeouts can be installed");
|
|
return -ENOMEM;
|
|
}
|
|
|
|
clock_dev = device_get_binding(config->clock_name);
|
|
if (clock_dev == NULL) {
|
|
return -EINVAL;
|
|
}
|
|
|
|
if (clock_control_get_rate(clock_dev, config->clock_subsys,
|
|
&clock_freq)) {
|
|
return -EINVAL;
|
|
}
|
|
|
|
WDOG_GetDefaultConfig(&data->wdog_config);
|
|
|
|
data->wdog_config.timeoutValue = clock_freq * cfg->window.max / 1000U;
|
|
|
|
if (cfg->window.min) {
|
|
data->wdog_config.enableWindowMode = true;
|
|
data->wdog_config.windowValue =
|
|
clock_freq * cfg->window.min / 1000U;
|
|
} else {
|
|
data->wdog_config.enableWindowMode = false;
|
|
data->wdog_config.windowValue = 0;
|
|
}
|
|
|
|
if ((data->wdog_config.timeoutValue < MIN_TIMEOUT) ||
|
|
(data->wdog_config.timeoutValue < data->wdog_config.windowValue)) {
|
|
LOG_ERR("Invalid timeout");
|
|
return -EINVAL;
|
|
}
|
|
|
|
data->wdog_config.clockSource = kWDOG_LpoClockSource;
|
|
data->wdog_config.enableInterrupt = cfg->callback != NULL;
|
|
data->callback = cfg->callback;
|
|
data->timeout_valid = true;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int mcux_wdog_feed(const struct device *dev, int channel_id)
|
|
{
|
|
const struct mcux_wdog_config *config = dev->config;
|
|
WDOG_Type *base = config->base;
|
|
|
|
if (channel_id != 0) {
|
|
LOG_ERR("Invalid channel id");
|
|
return -EINVAL;
|
|
}
|
|
|
|
WDOG_Refresh(base);
|
|
LOG_DBG("Fed the watchdog");
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void mcux_wdog_isr(const struct device *dev)
|
|
{
|
|
const struct mcux_wdog_config *config = dev->config;
|
|
struct mcux_wdog_data *data = dev->data;
|
|
WDOG_Type *base = config->base;
|
|
uint32_t flags;
|
|
|
|
flags = WDOG_GetStatusFlags(base);
|
|
WDOG_ClearStatusFlags(base, flags);
|
|
|
|
if (data->callback) {
|
|
data->callback(dev, 0);
|
|
}
|
|
}
|
|
|
|
static int mcux_wdog_init(const struct device *dev)
|
|
{
|
|
const struct mcux_wdog_config *config = dev->config;
|
|
|
|
config->irq_config_func(dev);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct wdt_driver_api mcux_wdog_api = {
|
|
.setup = mcux_wdog_setup,
|
|
.disable = mcux_wdog_disable,
|
|
.install_timeout = mcux_wdog_install_timeout,
|
|
.feed = mcux_wdog_feed,
|
|
};
|
|
|
|
static void mcux_wdog_config_func_0(const struct device *dev);
|
|
|
|
static const struct mcux_wdog_config mcux_wdog_config_0 = {
|
|
.base = (WDOG_Type *) DT_INST_REG_ADDR(0),
|
|
.clock_name = DT_INST_CLOCKS_LABEL(0),
|
|
.clock_subsys = (clock_control_subsys_t)
|
|
DT_INST_CLOCKS_CELL(0, name),
|
|
.irq_config_func = mcux_wdog_config_func_0,
|
|
};
|
|
|
|
static struct mcux_wdog_data mcux_wdog_data_0;
|
|
|
|
DEVICE_AND_API_INIT(mcux_wdog_0, DT_INST_LABEL(0),
|
|
&mcux_wdog_init,
|
|
&mcux_wdog_data_0, &mcux_wdog_config_0,
|
|
POST_KERNEL, CONFIG_KERNEL_INIT_PRIORITY_DEVICE,
|
|
&mcux_wdog_api);
|
|
|
|
static void mcux_wdog_config_func_0(const struct device *dev)
|
|
{
|
|
IRQ_CONNECT(DT_INST_IRQN(0),
|
|
DT_INST_IRQ(0, priority),
|
|
mcux_wdog_isr, DEVICE_GET(mcux_wdog_0), 0);
|
|
|
|
irq_enable(DT_INST_IRQN(0));
|
|
}
|