mirror of
https://github.com/zephyrproject-rtos/zephyr
synced 2025-09-04 08:21:57 +00:00
2d7460482d
This commit refactors kernel and arch headers to establish a boundary
between private and public interface headers.
The refactoring strategy used in this commit is detailed in the issue
This commit introduces the following major changes:
1. Establish a clear boundary between private and public headers by
removing "kernel/include" and "arch/*/include" from the global
include paths. Ideally, only kernel/ and arch/*/ source files should
reference the headers in these directories. If these headers must be
used by a component, these include paths shall be manually added to
the CMakeLists.txt file of the component. This is intended to
discourage applications from including private kernel and arch
headers either knowingly and unknowingly.
- kernel/include/ (PRIVATE)
This directory contains the private headers that provide private
kernel definitions which should not be visible outside the kernel
and arch source code. All public kernel definitions must be added
to an appropriate header located under include/.
- arch/*/include/ (PRIVATE)
This directory contains the private headers that provide private
architecture-specific definitions which should not be visible
outside the arch and kernel source code. All public architecture-
specific definitions must be added to an appropriate header located
under include/arch/*/.
- include/ AND include/sys/ (PUBLIC)
This directory contains the public headers that provide public
kernel definitions which can be referenced by both kernel and
application code.
- include/arch/*/ (PUBLIC)
This directory contains the public headers that provide public
architecture-specific definitions which can be referenced by both
kernel and application code.
2. Split arch_interface.h into "kernel-to-arch interface" and "public
arch interface" divisions.
- kernel/include/kernel_arch_interface.h
* provides private "kernel-to-arch interface" definition.
* includes arch/*/include/kernel_arch_func.h to ensure that the
interface function implementations are always available.
* includes sys/arch_interface.h so that public arch interface
definitions are automatically included when including this file.
- arch/*/include/kernel_arch_func.h
* provides architecture-specific "kernel-to-arch interface"
implementation.
* only the functions that will be used in kernel and arch source
files are defined here.
- include/sys/arch_interface.h
* provides "public arch interface" definition.
* includes include/arch/arch_inlines.h to ensure that the
architecture-specific public inline interface function
implementations are always available.
- include/arch/arch_inlines.h
* includes architecture-specific arch_inlines.h in
include/arch/*/arch_inline.h.
- include/arch/*/arch_inline.h
* provides architecture-specific "public arch interface" inline
function implementation.
* supersedes include/sys/arch_inline.h.
3. Refactor kernel and the existing architecture implementations.
- Remove circular dependency of kernel and arch headers. The
following general rules should be observed:
* Never include any private headers from public headers
* Never include kernel_internal.h in kernel_arch_data.h
* Always include kernel_arch_data.h from kernel_arch_func.h
* Never include kernel.h from kernel_struct.h either directly or
indirectly. Only add the kernel structures that must be referenced
from public arch headers in this file.
- Relocate syscall_handler.h to include/ so it can be used in the
public code. This is necessary because many user-mode public codes
reference the functions defined in this header.
- Relocate kernel_arch_thread.h to include/arch/*/thread.h. This is
necessary to provide architecture-specific thread definition for
'struct k_thread' in kernel.h.
- Remove any private header dependencies from public headers using
the following methods:
* If dependency is not required, simply omit
* If dependency is required,
- Relocate a portion of the required dependencies from the
private header to an appropriate public header OR
- Relocate the required private header to make it public.
This commit supersedes #20047, addresses #19666, and fixes #3056.
Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
101 lines
2.5 KiB
C
101 lines
2.5 KiB
C
/*
|
|
* Copyright (c) 2018 Oticon A/S
|
|
*
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*
|
|
* Pseudo-random entropy generator for the ARCH_POSIX architecture:
|
|
* Following the principle of reproducibility of the native_posix board
|
|
* this entropy device will always generate the same random sequence when
|
|
* initialized with the same seed
|
|
*
|
|
* This entropy source should only be used for testing.
|
|
*/
|
|
|
|
#include "device.h"
|
|
#include <drivers/entropy.h>
|
|
#include "init.h"
|
|
#include <sys/util.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <arch/posix/posix_trace.h>
|
|
#include "soc.h"
|
|
#include "cmdline.h" /* native_posix command line options header */
|
|
|
|
static unsigned int seed = 0x5678;
|
|
|
|
static int entropy_native_posix_get_entropy(struct device *dev, u8_t *buffer,
|
|
u16_t length)
|
|
{
|
|
ARG_UNUSED(dev);
|
|
|
|
while (length) {
|
|
/*
|
|
* Note that only 1 thread (Zephyr thread or HW models), runs at
|
|
* a time, therefore there is no need to use random_r()
|
|
*/
|
|
long int value = random();
|
|
|
|
size_t to_copy = MIN(length, sizeof(long int));
|
|
|
|
memcpy(buffer, &value, to_copy);
|
|
buffer += to_copy;
|
|
length -= to_copy;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int entropy_native_posix_get_entropy_isr(struct device *dev, u8_t *buf,
|
|
u16_t len, u32_t flags)
|
|
{
|
|
ARG_UNUSED(flags);
|
|
|
|
/*
|
|
* entropy_native_posix_get_entropy() is also safe for ISRs
|
|
* and always produces data.
|
|
*/
|
|
return entropy_native_posix_get_entropy(dev, buf, len);
|
|
}
|
|
|
|
static int entropy_native_posix_init(struct device *dev)
|
|
{
|
|
ARG_UNUSED(dev);
|
|
srandom(seed);
|
|
posix_print_warning("WARNING: "
|
|
"Using a test - not safe - entropy source\n");
|
|
return 0;
|
|
}
|
|
|
|
static const struct entropy_driver_api entropy_native_posix_api_funcs = {
|
|
.get_entropy = entropy_native_posix_get_entropy,
|
|
.get_entropy_isr = entropy_native_posix_get_entropy_isr
|
|
};
|
|
|
|
DEVICE_AND_API_INIT(entropy_native_posix, CONFIG_ENTROPY_NAME,
|
|
entropy_native_posix_init, NULL, NULL,
|
|
PRE_KERNEL_1, CONFIG_KERNEL_INIT_PRIORITY_DEVICE,
|
|
&entropy_native_posix_api_funcs);
|
|
|
|
static void add_fake_entropy_option(void)
|
|
{
|
|
static struct args_struct_t entropy_options[] = {
|
|
/*
|
|
* Fields:
|
|
* manual, mandatory, switch,
|
|
* option_name, var_name ,type,
|
|
* destination, callback,
|
|
* description
|
|
*/
|
|
{false, false, false,
|
|
"seed", "r_seed", 'u',
|
|
(void *)&seed, NULL,
|
|
"A 32-bit integer seed value for the entropy device, such as "
|
|
"97229 (decimal), 0x17BCD (hex), or 0275715 (octal)"},
|
|
ARG_TABLE_ENDMARKER
|
|
};
|
|
|
|
native_add_command_line_opts(entropy_options);
|
|
}
|
|
|
|
NATIVE_TASK(add_fake_entropy_option, PRE_BOOT_1, 10);
|