mirror of
https://github.com/zephyrproject-rtos/zephyr
synced 2025-08-03 05:43:45 +00:00
f752c5eeec
The west build command has historically tried not to rm -rf directories that don't look like zephyr build directories. The way it does this is by checking for the presence of a CMake cache with a Zephyr-specific variable (ZEPHYR_TOOLCHAIN_VARIANT) in it. The problem with this approach is that if the build system fails before this cache variable is set, the directory doesn't look like a zephyr build directory, and therefore west build won't make it pristine even with --pristine=always, even though build directories resulting from failed runs like that are almost certainly irrecoverably broken and need to be made pristine before anything will work. This leads to users having to rm -rf their directories manually, which is not so nice. To avoid this from happening, just check for ZEPHYR_BASE, which is set early on in ZephyrConfig.cmake in 'modern' zephyr build systems. Keep the ZEPHYR_TOOLCHAIN_VARIANT check in place for compatibility. We could consider being less selective and just using shutil.rmtree() whenever we have --pristine=always, but that would be a bigger behavioral change than I'm comfortable doing without a good reason. Fixes: #28876 Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no> |
||
|---|---|---|
| .. | ||
| completion | ||
| runners | ||
| tests | ||
| boards.py | ||
| build_helpers.py | ||
| build.py | ||
| completion.py | ||
| debug.py | ||
| export.py | ||
| flash.py | ||
| mypy.ini | ||
| README.txt | ||
| run_common.py | ||
| run_tests.py | ||
| sign.py | ||
| zcmake.py | ||
| zephyr_ext_common.py | ||
This directory contains implementations for west commands which are tightly coupled to the zephyr tree. This includes the build, flash, and debug commands. Before adding more here, consider whether you might want to put new extensions in upstream west. For example, any commands which operate on the multi-repo need to be in upstream west, not here. Try to limit what goes in here to Zephyr-specific features. When extending this code, please keep the unit tests (in tests/) up to date. The mypy static type checker is also run on the runners package. To run these tests locally on Windows, run: py -3 run_tests.py On macOS and Linux: ./run_tests.py Note that these tests are run as part of Zephyr's CI when submitting an upstream pull request, and pull requests which break the tests cannot be merged. Thanks!